add area join support and test (#381) #397
Conversation
There was a problem hiding this comment.
Hi @marcin-krystianc
I'm confused about this. Which address should I provide for the test?
There was a problem hiding this comment.
Did you try to run it locally ? What are the logs in the consul agent?
There was a problem hiding this comment.
It's an EnterpriseOnlyFact so it skips when running locally.
There was a problem hiding this comment.
It is possible to run enterprise tests locally. You can download the old version (e.g. 1.9+ent of enterprise consul which will run locally for an hour). Then you need either set the appropriate env variable or just replace the tests attribute with [Fact].
There was a problem hiding this comment.
@marcin-krystianc here is the response from the consul agent
There was a problem hiding this comment.
I don't know that consul feature, so I'm not sure if it is even possible to make a successful area join request.
In worst case we can have a test with an unsuccessful call and an assertion for the exception we get back.
There was a problem hiding this comment.
Thanks @marcin-krystianc I guess i can mark this as a draft and come back to it later.
No description provided.