-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second step of moving to internal functions #395
Draft
Snuffy2
wants to merge
20
commits into
FutureTense:main
Choose a base branch
from
Snuffy2:2nd-PR-of-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,631
−2,397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename KeymasterLock entities from lock to kmlock Rename KeymasterLock parent to parent_name
Snuffy2
force-pushed
the
2nd-PR-of-rewrite
branch
from
November 16, 2024 14:42
5977c06
to
2ba442d
Compare
Snuffy2
force-pushed
the
2nd-PR-of-rewrite
branch
from
November 16, 2024 15:59
2ba442d
to
ee2e81a
Compare
Snuffy2
force-pushed
the
2nd-PR-of-rewrite
branch
from
November 16, 2024 23:46
556b74e
to
5b19f67
Compare
Snuffy2
force-pushed
the
2nd-PR-of-rewrite
branch
from
November 17, 2024 01:11
a702381
to
ca6a600
Compare
Snuffy2
force-pushed
the
2nd-PR-of-rewrite
branch
from
November 17, 2024 05:17
e97a9e5
to
3a7bd3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next PR based on #394
Breaking change
Please do not merge this into main/master. Maybe into a beta branch for those who'd like to help or test?
Functionality in this PR
To Do before this PR is ready
To Do in future PRs
Type of change
Additional information