Set skipDependencyErrors to true
#3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
small
|
The dependency system is definitely half-baked. It works great on the Polymod side, but to work in an intuitive way, it requires that the I'll approve this change but it should be reverted at some point in the future. |
EliteMasterEric
added
type: minor bug
Kade-github
pushed a commit
to Kade-github/Funkin
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Partially fixes/implements #3991
Briefly describe the issue(s) fixed.
Currently, Funkin' will refuse to load any mods at all if one mod has a missing dependency. This can cause a bit of confusion for someone just trying to mod the game.
This PR sets
skipDependencyErrorsto true, which only skips mods that have missing dependencies, instead of disabling every mod.Side note: There should probably be a popup or something to notify the user if a dependency error has occurred. That's something for another PR.