Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Preference Descriptions + Other Tweaks #3872

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[ENHANCEMENT] Preference Descriptions + Other Tweaks #3872

merged 2 commits into from
Jan 17, 2025

Conversation

anysad
Copy link
Contributor

@anysad anysad commented Nov 18, 2024

Does this PR close any issues? If so, link them below.

Briefly describe the issue(s) fixed.

  • This PR adds the missing descriptions for each of the options,
  • This PR updates the already pre-existing descriptions to be more... understandable ig?
  • This PR updates the camera deadzone so that when you scrolled down to the next option, it won't have as much as not needed space as before.

Include any relevant screenshots or videos.

2024-11-18.16-46-16.mp4

@github-actions github-actions bot added medium A medium pull request with 100 or fewer changes haxe Issue/PR modifies game code labels Nov 18, 2024
@sphis-Sinco
Copy link

This would be a good addition

@sphis-Sinco
Copy link

YEAH

@amyspark-ng
Copy link
Contributor

this will be huge if merged

@ninjamuffin99
Copy link
Member

i do like dis

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jan 17, 2025
@EliteMasterEric EliteMasterEric merged commit a17b0e8 into FunkinCrew:develop Jan 17, 2025
2 checks passed
@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jan 17, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 17, 2025
Kade-github pushed a commit to Kade-github/Funkin that referenced this pull request Jan 17, 2025
@anysad @Kade-github
[ENHANCEMENT] Preference Descriptions + Other Tweaks (FunkinCrew#3872)
3701681 
* updated preference menu

* update comment
@Stompyyyy
Copy link

finally accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JVNpixels JVNpixels JVNpixels approved these changes

Assignees
No one assigned
Labels
haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
7 participants
@anysad @sphis-Sinco @amyspark-ng @ninjamuffin99 @Stompyyyy @JVNpixels @EliteMasterEric