[BUGFIX] Fixes the Song repeating infinitely due to the Vocals being longer than the Instrumental

[KoloInDaCrib]

Does this PR close any issues? If so, link them below.

3142 and at least 7 duplicate issues that I wont even bother to list

Briefly describe the issue(s) fixed.

The dastardly resyncVocals is at it again! I've simply set the endTime variable of both Vocals and Inst to the same value, specifically to the lower of the two. That way no song should be repeating infinitely I hope! This was tested on Senpai Erect, which suffered from the issue, and Thorns Erect, which didnt but I wanted to check either way

Include any relevant screenshots or videos.

2024-10-26.09-59-18.mp4

(ignore me being dogshit at the game)
oh and also i would appreciate more testing on this! it will remain as a draft for a bit since I had only tested it on two songs but feel free to take a gander!

[NotHyper-474]

I wonder if this affects issue #2921 too

[KoloInDaCrib]

I wonder if this affects issue #2921 too

I guess? Since I made it so that the shortest audio is used to determine the end of the song, haven't even seen the issue let alone test it at all lol

[KutikiPlayz]

it might be better if you did the longest audio instead of shortest, or just cap them all at the instrumental length, cuz I can imagine a case where a composer cuts one vocal file down in length cuz they stop singing before the end of the song, and then the song ends entirely because that one file is shorter

[KoloInDaCrib]

it might be better if you did the longest audio instead of shortest, or just cap them all at the instrumental length, cuz I can imagine a case where a composer cuts one vocal file down in length cuz they stop singing before the end of the song, and then the song ends entirely because that one file is shorter

Probably, though I am unsure as to how I would go about extending the timer of the audio files without outright making the bug happen again, since longer voice files were the reason the infinite song bug happened in the first place (courtest of NotHyper for finding it out). Flixel already handled the shorter audio files via endTime variable in FlxSound.
I am of the opinion that having to do a janky solution and manually extend vocals in programs like Audacity would be better than having a chance for the bug to occur again.

And no, pausing/stopping the audio did not work. I have tried it already. It triggered resyncVocals regardless.

[moxie-coder]

I remember the original solution was to stop the vocals or just turn the volume to 0 when they ended, like seen in the Week 7 source code, but I don’t know if it truely worked well

[KutikiPlayz]

yeah if there's anything too short just stop it so it doesn't loop or anything