[BUGFIX] Chart Editor/Gameplay: Fixes countdown and audio artifacts with offsets #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft rn as i'm still fixing some weird stuff |
EliteMasterEric
added
the
status: pending triage
use the new bool to tell if we should start the song add a public static bool to countdown: finished
redundant trace removal
Fix a tiny little issue with vocal resync @ start
Kade-github
force-pushed
the
offset-fixer
branch
from
9d7cf34 to
a8aeae4
Compare
|
squashed a bunch of commits to make it less spammy on commits |
|
The last commit was to kind of fix a nasty bug with offsets that causes vocals to be desynced, to fix this i made the tolerance for resyncVocals 5 instead of 100. Didn't seem to affect me that harshly, but it might on lower end devices. I tested on HTML5 and it went well so be aware. |
EliteMasterEric
added
status: accepted
|
i find it funny how my sync fix also fucks with the audio, epic pr tho! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Don't think anyone uses these so no.
Briefly describe the issue(s) fixed.
Fixes an issue with offsets that would cause it to mass resync vocals, or go forward in time and back really quickly. Causing a lot of artifacts, lagging the game, and being unpleasant.
This also fixes the song starting before the countdown (due to the offset).
Include any relevant screenshots or videos.
This shows blammed at +1 second of instrumental offset.
https://github.com/user-attachments/assets/021e5b06-f67c-491a-8e17-d77bddf9c8be
(2nd clip is accidently the normal version of blammed instead of hard, but the point stands)