Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instances of CAN_OPEN_LINKS with FEATURE_OPEN_URL #3342

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

AbnormalPoof
Copy link
Contributor

Does this PR close any issues? If so, link them below.

Closes #3340

Briefly describe the issue(s) fixed.

This PR replaces all instances of CAN_OPEN_LINKS with FEATURE_OPEN_URL. The former was removed and replaced with the latter when the game's project file was switched from Project.xml to project.hxp, but it seems as if the code wasn't accounted for this change.

@EliteMasterEric EliteMasterEric self-assigned this Sep 17, 2024
@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage The bug or PR has not been reviewed yet. labels Sep 18, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 19, 2024
@ninjamuffin99 ninjamuffin99 merged commit d81e09b into FunkinCrew:develop Sep 30, 2024
@AbnormalPoof AbnormalPoof deleted the bugfix/opening-urls branch September 30, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants