Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert broken PR #3533

Closed
wants to merge 2 commits into from
Closed

chore: revert broken PR #3533

wants to merge 2 commits into from

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Jan 3, 2025

This reverts commit e8a8c71 (#3503), which broke CI:

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@arboleya arboleya self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:03am
ts-docs 🛑 Canceled (Inspect) Jan 3, 2025 10:03am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:03am

@github-actions github-actions bot added the chore Issue is a chore label Jan 3, 2025
@arboleya arboleya marked this pull request as ready for review January 3, 2025 09:51
@arboleya arboleya enabled auto-merge (squash) January 3, 2025 09:51
@arboleya arboleya disabled auto-merge January 3, 2025 10:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report:

Lines Branches Functions Statements
77.78%(+0%) 70.4%(+0%) 75.38%(+0%) 77.74%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94
Copy link
Contributor

The fix passed, closed in favour of:

@petertonysmith94 petertonysmith94 deleted the aa/chore/revert-broken-pr branch January 3, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@arboleya arboleya

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arboleya @petertonysmith94 @danielbate @nedsalk