fix: fuels dev hangs after compilation errors
#3504
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR is published in NPM with version 0.0.0-pr-3504-20241227154428 |
CodSpeed Performance ReportMerging #3504 will degrade performances by 48.39%Comparing Summary
Benchmarks breakdown
|
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate and
nedsalk
as code owners
| // because forc logs out 'Aborting due to 2 compilation errors' etc. | ||
| onForcError(reject); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I tried compiling an invalid project with forc build and it exited with an error code 1, so it seems to me that we shouldn't be parsing forc logs but rather just throwing if forc build exits with a non-zero code. Line 37: forc.on('error', onError) should've caught this but it didn't 🤔 Did you investigate this avenue?
There was a problem hiding this comment.
forc.on('error, onError) doesn't do anything because forc sends error messages to stdErr alongside other normal logs
|
Coverage Report:
Changed Files:
|
fuels devhangs on generating types #1886Release notes
In this release, we:
fuels devwould hang after a Sway compilation errorSummary
This PR fixes the issue where
fuels devwould hang after a Sway compilation error.To test:
pnpm create fuels@pr-3504pnpm fuels:devandpnpm devChecklist