-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validation and handling of unsafe integers #3491
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3491 will degrade performances by 20.27%Comparing Summary
Benchmarks breakdown
|
b68944c
const value: number = 76472027892439376; | ||
|
||
expect(() => coder.encode(value)).toThrow( | ||
new FuelError(ErrorCode.ENCODE_ERROR, 'Invalid u64 type - number value is too large.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new FuelError(ErrorCode.ENCODE_ERROR, 'Invalid u64 type - number value is too large.') | |
new FuelError(ErrorCode.ENCODE_ERROR, 'Invalid u64 type - too large. Number can only safely handle up to 53 bits'). |
JW if it needs more detail
Coverage Report:
Changed Files:Coverage values did not change👌. |
Release notes
In this release, we:
BigNumberCoder
Summary
Checklist