Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fuels UI integration test script to TS script #3478

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

maschad
Copy link
Member

@maschad maschad commented Dec 13, 2024

Summary

When running create-fuels the generated project requires users on unix-based systems to run chmod +x ./test/ui/test-ui.sh to run the UI integration tests. Interestingly, the currently committed test-ui.sh currently has the correct permissions i.e. -rwxr-xr-x but npm doesn't seem to preserve the Unix permissions in it's distribution.

This just converts the bash script into a TS script that is run via tsx to avoid such an issue.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:10pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:10pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:10pm

@github-actions github-actions bot added the chore Issue is a chore label Dec 13, 2024
@maschad maschad changed the title build: convert UI tests to ts script chore: convert UI integration tests to TS scripts Dec 13, 2024
Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #3478 will not alter performance

Comparing mc/fix/convert-ui-test-scripts-to-ts (b5a2ebb) with master (41c72fb)

Summary

✅ 18 untouched benchmarks

@maschad maschad changed the title chore: convert UI integration tests to TS scripts chore: fuels UI integration test script to TS script Dec 13, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(+0%) 69.84%(+0%) 74.2%(+0%) 76.34%(+0%)
Changed Files:

Coverage values did not change👌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant