Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add assets to account check utility #3417

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: add assets to account check utility #3417

wants to merge 2 commits into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Nov 22, 2024 •
edited
Loading

Release notes

In this release, we:

  • Modified the Provider methods isUserAccount and getAddressType so that assets are considered when checking if an address is an account

Summary

The isUserAccount and getAddressType also check addresses to see if they are asset addresses

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 9:37pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 9:37pm
ts-docs-api ❌ Failed (Inspect) Nov 22, 2024 9:37pm

@github-actions github-actions bot added the feat Issue is a feature label Nov 22, 2024
@maschad maschad self-assigned this Nov 22, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #3417 will not alter performance

Comparing mc/feat/check-in-account-utility (fc5347d) with master (27e8808)

Summary

✅ 18 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm will be requested when the pull request is marked ready for review digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya will be requested when the pull request is marked ready for review arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf will be requested when the pull request is marked ready for review Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 will be requested when the pull request is marked ready for review Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate will be requested when the pull request is marked ready for review danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk will be requested when the pull request is marked ready for review nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 will be requested when the pull request is marked ready for review petertonysmith94 is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@maschad maschad

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider assets in check-account utility
1 participant
@maschad