fix: transaction estimation for InputMessage containing data
#3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
This PR is published in NPM with version 0.0.0-pr-3068-20240831093013 |
arboleya
requested changes
Aug 31, 2024
|
|
||
| // We only consider the message input if it has no data. | ||
| // Messages with `data` cannot fund the gas of a transaction. | ||
| if (input.type === InputType.Message && bn(input.data).isZero()) { |
There was a problem hiding this comment.
Adding a test covering this would be great, and then we're good to go.
There was a problem hiding this comment.
@Torres-ssf I assume as you've self assigned you'll add the test for this?
arboleya
changed the title
InputMessage containing data
|
Coverage Report:
Changed Files:
|
4 tasks
|
Closing in favor of #3078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
InputMessagecontainsdataSummary
Messages with
datacannot fund transactions.This would happen in Fuel accounts that received a deposit from an
ERC20token (like in the Bridge).Checklist