Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added typegen test for type with native asset #3066

Merged
merged 11 commits into from
Sep 6, 2024
Merged

chore: added typegen test for type with native asset #3066

merged 11 commits into from
Sep 6, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 30, 2024 •
edited
Loading

Summary

  • Incoming from the forum.
  • Adds typegen level tests for aliases types

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Aug 30, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 30, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 8:57am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 8:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 6, 2024 8:57am

@petertonysmith94
Copy link
Contributor Author

Closed as this appears to be an issue in Sway:

@petertonysmith94 petertonysmith94 deleted the ps/chore/added-typegen-test-for-tuple-with-asset-id branch September 2, 2024 14:20
@petertonysmith94 petertonysmith94 mentioned this pull request Sep 6, 2024
Closed
@petertonysmith94 petertonysmith94 restored the ps/chore/added-typegen-test-for-tuple-with-asset-id branch September 6, 2024 07:54
@petertonysmith94 petertonysmith94 changed the base branch from master to aa/chore/upgrade-forc-to-0.63.4 September 6, 2024 08:05
arboleya
arboleya previously approved these changes Sep 6, 2024
View reviewed changes
@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 6, 2024 08:37
danielbate
danielbate previously approved these changes Sep 6, 2024
View reviewed changes
Base automatically changed from aa/chore/upgrade-forc-to-0.63.4 to master September 6, 2024 08:49
@arboleya arboleya dismissed stale reviews from danielbate and themself September 6, 2024 08:49

The base branch was changed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 72.15%(+0%) 77.73%(+0%) 79.43%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 8faeaa4 into master Sep 6, 2024
28 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/added-typegen-test-for-tuple-with-asset-id branch September 6, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@maschad maschad Awaiting requested review from maschad

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typegen fails when handling Sway type aliases
4 participants
@petertonysmith94 @arboleya @danielbate @nedsalk