-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove sway-libs
dep from testing fixtures
#2189
Conversation
packages/fuel-gauge/test/fixtures/forc-projects/bytecode-sway-lib/src/main.sw
Outdated
Show resolved
Hide resolved
@Dhaiwat10 @arboleya any ideas why this test would hang on CI? It works fine locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ideas why this test would hang on CI? It works fine locally
Nothing I can see only by reading it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern here is the docs still references the sway std lib function, so we are miss communicating the dependency. If the sway std lib signature changed, we are not in sync as we have a mocked version. I think we should be more generally referencing this as working with bytes with both a Vec<u8>
and Bytes
example. Thoughts?
Whether it's mocked or not wouldn't have an effect as it relates to breaking changes as we would still be using a particular version as our dependency the benefit with this at least would be should we try to upgrade, if there is a breaking change, Rust would let us know due to it's semver toolchain - but this would still be dependent on our manual attempt to upgrade. In summary, I'm not sure if there is an uncomplicated way to discuss working with bytecode or |
But agreed we should remove the dependency, like you have done.
I would personally prefer removing the reference to the sway std lib in the docs and just more generally speak about bytecode. Some functions require you to pass in bytecode to the function. The type of the bytecode parameter is usually `Vec<u8>`, this would be handled like so:
<-- code snippet --> |
|
c23dd22
to
2f6af7d
Compare
Coverage Report:
Changed Files:Coverage values did not change👌. |
Closes #2160
compute_bytecode
functions in the sway contracts