fix: validation and handling of unsafe integers #3491
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3491 will degrade performances by 20.27%Comparing Summary
Benchmarks breakdown
|
petertonysmith94
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
maschad
as code owners
Dhaiwat10
previously approved these changes
Dec 21, 2024
arboleya
previously approved these changes
Dec 23, 2024
petertonysmith94
changed the title
petertonysmith94
dismissed stale reviews from arboleya and Dhaiwat10
via
b68944c
arboleya
approved these changes
Dec 23, 2024
danielbate
reviewed
Dec 23, 2024
| const value: number = 76472027892439376; | ||
|
|
||
| expect(() => coder.encode(value)).toThrow( | ||
| new FuelError(ErrorCode.ENCODE_ERROR, 'Invalid u64 type - number value is too large.') |
There was a problem hiding this comment.
Suggested change
| new FuelError(ErrorCode.ENCODE_ERROR, 'Invalid u64 type - number value is too large.') | |
| new FuelError(ErrorCode.ENCODE_ERROR, 'Invalid u64 type - too large. Number can only safely handle up to 53 bits'). |
JW if it needs more detail
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
BigNumberCoderSummary
Checklist