chore: add validation for TX max outputs exceeded (#2899)

FuelLabs · Aug 8, 2024 · 1d2abd7 · 1d2abd7
1 parent b8c9174
commit 1d2abd7
Show file tree

Hide file tree

Showing 5 changed files with 69 additions and 4 deletions.
diff --git a/.changeset/stupid-planets-joke.md b/.changeset/stupid-planets-joke.md
@@ -0,0 +1,6 @@
+---
+"@fuel-ts/account": patch
+"@fuel-ts/errors": patch
+---
+
+chore: add validation for TX max outputs exceeded
diff --git a/apps/docs/src/guide/errors/index.md b/apps/docs/src/guide/errors/index.md
@@ -301,4 +301,8 @@ If you believe you found a bug, please report the [issue](https://github.com/Fue
 
 ### `MAX_INPUTS_EXCEEDED`
 
-When the number of transaction inputs exceeds the maximum limit allowed by the blockchain.
+When the number of transaction inputs exceeds the maximum limit allowed by the blockchain.
+
+### `MAX_OUTPUTS_EXCEEDED`
+
+When the number of transaction outputs exceeds the maximum limit allowed by the blockchain.
diff --git a/packages/account/src/providers/provider.test.ts b/packages/account/src/providers/provider.test.ts
@@ -590,7 +590,53 @@ describe('Provider', () => {
       () => sender.sendTransaction(request),
       new FuelError(
         ErrorCode.MAX_INPUTS_EXCEEDED,
-        'The transaction exceeds the maximum allowed number of inputs for funding.'
+        'The transaction exceeds the maximum allowed number of inputs.'
+      )
+    );
+  });
+
+  it('should throws if max of ouputs was exceeded', async () => {
+    const maxOutputs = 2;
+    using launched = await setupTestProviderAndWallets({
+      nodeOptions: {
+        snapshotConfig: {
+          chainConfig: {
+            consensus_parameters: {
+              V1: {
+                tx_params: {
+                  V1: {
+                    max_outputs: maxOutputs,
+                  },
+                },
+              },
+            },
+          },
+        },
+      },
+      walletsConfig: {
+        count: 3,
+      },
+    });
+
+    const {
+      wallets: [sender, receiver1, receiver2],
+      provider,
+    } = launched;
+
+    const baseAssetId = provider.getBaseAssetId();
+
+    const request = new ScriptTransactionRequest();
+    const resources = await sender.getResourcesToSpend([[1000, baseAssetId]]);
+    request.addCoinOutput(receiver1.address, 1, baseAssetId);
+    request.addCoinOutput(receiver2.address, 1, baseAssetId);
+
+    request.addResources(resources);
+
+    await expectToThrowFuelError(
+      () => sender.sendTransaction(request),
+      new FuelError(
+        ErrorCode.MAX_OUTPUTS_EXCEEDED,
+        'The transaction exceeds the maximum allowed number of outputs.'
       )
     );
   });

diff --git a/packages/account/src/providers/provider.ts b/packages/account/src/providers/provider.ts
@@ -696,10 +696,18 @@ Supported fuel-core version: ${supportedVersion}.`
   }
 
   private validateTransaction(tx: TransactionRequest, consensusParameters: ConsensusParameters) {
-    if (bn(tx.inputs.length).gt(consensusParameters.txParameters.maxInputs)) {
+    const { maxOutputs, maxInputs } = consensusParameters.txParameters;
+    if (bn(tx.inputs.length).gt(maxInputs)) {
       throw new FuelError(
         ErrorCode.MAX_INPUTS_EXCEEDED,
-        'The transaction exceeds the maximum allowed number of inputs for funding.'
+        'The transaction exceeds the maximum allowed number of inputs.'
+      );
+    }
+
+    if (bn(tx.outputs.length).gt(maxOutputs)) {
+      throw new FuelError(
+        ErrorCode.MAX_OUTPUTS_EXCEEDED,
+        'The transaction exceeds the maximum allowed number of outputs.'
       );
     }
   }

diff --git a/packages/errors/src/error-codes.ts b/packages/errors/src/error-codes.ts
@@ -78,6 +78,7 @@ export enum ErrorCode {
   TRANSACTION_SQUEEZED_OUT = 'transaction-squeezed-out',
   CONTRACT_SIZE_EXCEEDS_LIMIT = 'contract-size-exceeds-limit',
   MAX_INPUTS_EXCEEDED = 'max-inputs-exceeded',
+  MAX_OUTPUTS_EXCEEDED = 'max-outputs-exceeded',
 
   // receipt
   INVALID_RECEIPT_TYPE = 'invalid-receipt-type',