fault_proving(global_roots): scaffold global merkle root storage crate #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Jan 13, 2025
netrome
changed the title
|
Redefined the PR and issue after @xgreenx's proposal. I will do some further cleanups and create follow-up issues for the next steps, before marking this PR as ready for review. |
netrome
changed the title
netrome
force-pushed
the
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
branch
from
5935b3d to
f25d6d0
Compare
…e code duplication.
- Rename global merkle root storage crate - Add TODOS - Clean up stale comments - Rename TableColumns -> TableColumn
netrome
force-pushed
the
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
branch
from
20c4ac8 to
b3a2b04
Compare
This was referenced Jan 16, 2025
netrome
force-pushed
the
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
branch
from
524d43f to
cff896d
Compare
netrome
force-pushed
the
2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
branch
from
99ad6a9 to
cf3a62b
Compare
netrome
changed the title
xgreenx
reviewed
Jan 16, 2025
rymnc
reviewed
Jan 17, 2025
xgreenx
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2552
This PR adds a new crate with column definitions for the global state root service, which we intend to deploy as a standalone binary.
Moreover, this crate also contains a top-level function to populate these columns with data given a new block.