Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support Symfony 7 Update composer.json #25

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

Yozhef
Copy link

@Yozhef Yozhef commented Dec 1, 2023

No description provided.

@Yozhef
Copy link
Author

Yozhef commented Dec 1, 2023

Behat/Behat#1442

@Yozhef Yozhef changed the title Update composer.json Add support Symfony 7 Update composer.json Dec 1, 2023
@lchrusciel lchrusciel marked this pull request as draft December 9, 2023 18:57
@lchrusciel lchrusciel changed the title Add support Symfony 7 Update composer.json [WIP] Add support Symfony 7 Update composer.json Dec 9, 2023
@lchrusciel
Copy link
Member

Waiting for release of Behat/Behat#1442

@loic425 loic425 mentioned this pull request Dec 11, 2023
74 tasks
composer.json Outdated
@@ -22,9 +22,9 @@
],
"require": {
"php": ">=7.4",
"behat/behat": "^3.0.5",
"behat/behat": "dev-master",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper way to handle that is not to change the requirement but to use minimum-stability: dev in the symfony 7.0 job for now (this way, you won't loose the requirement for other versions).

And it would even make this PR mergeable (the release of the new version of this extension might still need to wait for the Behat release but not the merge), making it easier to validate that the extension actually works fine (by attempting to upgrade some projects to use dev versions of packages)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is for testing - we are waiting release Behat new version supports Symfony 7.0

@Yozhef Yozhef marked this pull request as ready for review January 11, 2024 09:08
@Yozhef Yozhef merged commit 8543360 into master Jan 11, 2024
16 checks passed
@Yozhef Yozhef deleted the update-composer-deps-Symfony-7 branch January 11, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants