Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#issue2174 #2519

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#issue2174 #2519

wants to merge 1 commit into from

Conversation

Zelongczl
Copy link

@Zelongczl Zelongczl commented Oct 28, 2023

This fixes issue #2174

Note: The click of passisve abilities, diabled abilities, noclick abilities, etc. will temporarily display cancel icon

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 28, 2023 9:34am

@ghost
Copy link

ghost commented Oct 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DreadKnight
Copy link
Member

@Zelongczl Heya! Seems pretty good, however, the cancel icon doesn't seem to for already used abilities as according to issue specs. It's nice that it also works for hotkeys, but it should trigger for the passive one (Q hotkey) if no abilities are usable atm.
Note that it would be useful to merge master in to easier test your branch, since it had issue #2506 unsolved, which makes clicking passive and basic attack icons very hard without some tinkering around.

@DreadKnight DreadKnight marked this pull request as draft October 30, 2023 01:04
@DreadKnight
Copy link
Member

@Zelongczl Heya! Can you poke at this a bit more so that we can finish with the PR before it goes stale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants