Add server-side session watchdog #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroulet
reviewed
Jun 12, 2024
asyncua/server/internal_session.py
Outdated
| @@ -59,13 +67,44 @@ async def get_endpoints(self, params=None, sockname=None): | |||
| def is_activated(self) -> bool: | |||
| return self.state == SessionState.Activated | |||
|
|
|||
| def update_last_action_time(func): | |||
There was a problem hiding this comment.
I understand what you want to do, but I have bad experience with that kind of decorators. they make stack trace a mess and completlu breaks typing checks. if we want t omerge that we at least need typing and check things with mypy (which probbaly only does not complain because since you do not have typing on decorator so it disabled itself)
There was a problem hiding this comment.
maybe it is better to update some timestamp at lower level when we receive a request which is dispatched to thata internal session. IS that possible?
There was a problem hiding this comment.
Good idea, I moved it into the UA processor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, to comply with section 5.6.2 of the spec, the server should close a session that is inactive within its session timeout:
I no longer think this will actually resolve anything in #116, but I think it's useful nonetheless if we want to comply with the spec.