Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Using Leanpub Course from view #32

Merged
merged 1 commit into from
Jul 30, 2024
Merged

remove Using Leanpub Course from view #32

merged 1 commit into from
Jul 30, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Jul 30, 2024

There was an error with a few plots rendering and it was because "Using Leanpub Course" seems to be on google analytics now and that gets pulled in as an "everyone" audience course so I had to filter it out.

@kweav
Copy link
Contributor Author

kweav commented Jul 30, 2024

I think there are some redundant filter calls in the app.R file, assuming the refresh data action has been run, but I know that right now they're also necessary to keep the Using Leanpub Course from view. So maybe the redundancy is ok?

I tried to rerun the refresh data action on my branch and remove the filter statements, but rerunning the action didn't update the files on my branch.

@kweav kweav merged commit b3a5298 into main Jul 30, 2024
1 check passed
@kweav kweav deleted the colorError branch July 30, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants