Updated Person card component + created People grid view component #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 31, 2020
There was a problem hiding this comment.
hey @nthnluu.
I just made a PR changing some file names and items around.
In that PR I have included all of your changes as well to eliminate any possible merge conflict.
I can sync up with you tomorrow regarding what I have done and moving forward.
@FranckNdame, don't merge this one in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Person card component to ensure the images are consistently sized and properly ARIA labeled (the alt text is simply "Image of {person.name}"). I also set up the CSS grid to display the People cards.