Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MP3 warning dialog #88

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove MP3 warning dialog #88

merged 2 commits into from
Jan 17, 2025

Conversation

naveensingh
Copy link
Member

@naveensingh naveensingh commented Jan 17, 2025

What is it?

  • Bugfix (?)
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Removed experimental warning dialog
  • Removed experimental warning strings

It was originally added for #81 but it does not seem necessary anymore. There is still a (experimental) suffix next to mp3 in settings which will be removed once we are sure about MP3's reliability.

Acknowledgement

The problem was fixed + there's already a `experimental` next to the format in settings.
@naveensingh naveensingh merged commit 417d4db into master Jan 17, 2025
5 of 7 checks passed
@naveensingh naveensingh deleted the remove_mp3_warning_dialog branch January 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant