New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle file descriptor properly #86

Merged

naveensingh merged 2 commits into master from fix-fd-invalidation

Jan 16, 2025

Member

naveensingh commented Jan 16, 2025 •

edited

Loading

What is it?

Bugfix
Feature
Codebase improvement

Description of the changes in your PR

Use ParcelFileDescriptor.dup() to create a duplicate FD.
Close resource properly using use

Fixes the following issue(s)

Fixes Recordings are not as long as they should be #81

Acknowledgement

I read the contribution guidelines.

naveensingh added 2 commits

January 16, 2025 19:20


          Minor code improvement

a6fd397


          Wrap file descriptor in parcel file descriptor

95f13fc

Closes #81

naveensingh merged commit 2b08af1 into master

4 of 6 checks passed

naveensingh deleted the fix-fd-invalidation branch

January 16, 2025 17:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet