Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map fixes and updates #177

Merged
merged 14 commits into from
Jan 29, 2024
Merged

Conversation

phellen007
Copy link
Contributor

Fix for a soft lock that happened in Slime guys, and overhaul/update to Turtle Fortress

Fixed an issue with the board where appearance event card/square characters could get softlocked.
Basically a complete overhaul of this board.
Moved the location of the 4 magmalice to the center of each side. Goal of this change is to increase the amount of player traffic in the four corners of the map, and take away some of the ability to avoid landing on dangerous properties.
included the webps this time.
Found a waypoint error in frb1. This fixes it.
Soph's original map + some collaborative ideas
@Sophilautia
Copy link
Collaborator

Sophilautia commented Jan 25, 2024

Can you please complete this checklist to the best of your ability for each of the changed / new boards:

  • Board passes validation script

  • Files are in correct folders

  • All FRBs pass possible paths check (under 70 iirc)

  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)

  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)

  • All backstreet destinations are as intended

  • YAML is formatted correctly

  • YAML has author and changelog

  • YAML has Author's URL (or doesn't have one if not wanted)

  • Files and folders have no special characters / spaces / capitalisations

  • Map icon is included, follows existing template, and is correctly implemented in yaml

  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)

  • Music is properly implemented and uploaded to server

  • All looping music is looping, and all non-looping music isn't looping

  • There are exactly 64 venture cards

  • IF Venture card 45 is active, then there must be both an arcade & take a break square

  • IF Venture card 125 is active, then there must be both an arcade & boon square

  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive

  • Max dice roll is below 10

  • You can't travel between three sets of doors in one roll


IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors

  • You can't travel between two sets of doors in one roll


IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll

  • Venture card 87 is inactive


IF max dice roll is 6:

  • Venture card 87 is inactive

  • Venture card 115 is inactive


  • Balloonport test has been completed on emulator OR console

  • Balloonport test has been completed on console

  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)

  • A full game of the board has been played by humans

  • All music has been tested and volumes are OK

Theme is the same, but the rest of the board has been edited/revamped.
@phellen007
Copy link
Contributor Author

phellen007 commented Jan 25, 2024

Only thing(s) that isnt checked for all of these yet is running 3 games with npcs, and I can't do the balloon test on a console since I don't play FS on console.

@phellen007
Copy link
Contributor Author

Super Bowser's Trackway

  • Board passes validation script
  • Files are in correct folders
  • All FRBs pass possible paths check (under 70 iirc)
  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)
  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
  • All backstreet destinations are as intended
  • YAML is formatted correctly
  • YAML has author and changelog
  • YAML has Author's URL (or doesn't have one if not wanted)
  • Files and folders have no special characters / spaces / capitalisations
  • Map icon is included, follows existing template, and is correctly implemented in yaml
  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
  • Music is properly implemented and uploaded to server
  • All looping music is looping, and all non-looping music isn't looping
  • There are exactly 64 venture cards
  • IF Venture card 45 is active, then there must be both an arcade & take a break square
  • IF Venture card 125 is active, then there must be both an arcade & boon square
  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
  • Max dice roll is below 10
  • You can't travel between three sets of doors in one roll

IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors
  • You can't travel between two sets of doors in one roll

IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll
  • Venture card 87 is inactive

IF max dice roll is 6:

  • Venture card 87 is inactive

  • Venture card 115 is inactive

  • Balloonport test has been completed on emulator OR console

  • Balloonport test has been completed on console

  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)

  • A full game of the board has been played by humans

  • All music has been tested and volumes are OK

Same as previous upload, just nudged a square to make the map look more symmetrical.
@phellen007
Copy link
Contributor Author

Castaway Bay Cside

  • Board passes validation script
  • Files are in correct folders
  • All FRBs pass possible paths check (under 70 iirc)
  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)
  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
  • All backstreet destinations are as intended
  • YAML is formatted correctly
  • YAML has author and changelog
  • YAML has Author's URL (or doesn't have one if not wanted)
  • Files and folders have no special characters / spaces / capitalisations
  • Map icon is included, follows existing template, and is correctly implemented in yaml
  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
  • Music is properly implemented and uploaded to server
  • All looping music is looping, and all non-looping music isn't looping
  • There are exactly 64 venture cards
  • IF Venture card 45 is active, then there must be both an arcade & take a break square
  • IF Venture card 125 is active, then there must be both an arcade & boon square
  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
  • Max dice roll is below 10
  • You can't travel between three sets of doors in one roll

IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors
  • You can't travel between two sets of doors in one roll

IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll
  • Venture card 87 is inactive

IF max dice roll is 6:

  • Venture card 87 is inactive
  • Venture card 115 is inactive
  • Balloonport test has been completed on emulator OR console
  • Balloonport test has been completed on console
  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)
  • A full game of the board has been played by humans
  • All music has been tested and volumes are OK

Kept the target at 16 target. Passes the check list
@Ennesan
Copy link
Contributor

Ennesan commented Jan 27, 2024

Castaway Bay - CSide, but if there is more than one author on the board, please split it into multiple lines.

@phellen007
Copy link
Contributor Author

Slime Guys Payday Express

  • Board passes validation script
  • Files are in correct folders
  • All FRBs pass possible paths check (under 70 iirc)
  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)
  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
  • All backstreet destinations are as intended
  • YAML is formatted correctly
  • YAML has author and changelog
  • YAML has Author's URL (or doesn't have one if not wanted)
  • Files and folders have no special characters / spaces / capitalisations
  • Map icon is included, follows existing template, and is correctly implemented in yaml
  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
  • Music is properly implemented and uploaded to server
  • All looping music is looping, and all non-looping music isn't looping
  • There are exactly 64 venture cards
  • IF Venture card 45 is active, then there must be both an arcade & take a break square
  • IF Venture card 125 is active, then there must be both an arcade & boon square
  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
  • Max dice roll is below 10
  • You can't travel between three sets of doors in one roll

IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors
  • You can't travel between two sets of doors in one roll

IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll
  • Venture card 87 is inactive

IF max dice roll is 6:

  • Venture card 87 is inactive
  • Venture card 115 is inactive
  • Balloonport test has been completed on emulator OR console
  • Balloonport test has been completed on console
  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)
  • A full game of the board has been played by humans
  • All music has been tested and volumes are OK

fixed the names section to have seperate lines in the yaml
@phellen007
Copy link
Contributor Author

Castaway Bay - CSide, but if there is more than one author on the board, please split it into multiple lines.

Thanks, I fixed this and resent the PR

Just adjusting the author name so they are consistent across the board(s)
@phellen007
Copy link
Contributor Author

Turtle Fortress

  • Board passes validation script
  • Files are in correct folders
  • All FRBs pass possible paths check (under 70 iirc)
  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)
  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
  • All backstreet destinations are as intended
  • YAML is formatted correctly
  • YAML has author and changelog
  • YAML has Author's URL (or doesn't have one if not wanted)
  • Files and folders have no special characters / spaces / capitalisations
  • Map icon is included, follows existing template, and is correctly implemented in yaml
  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
  • Music is properly implemented and uploaded to server
  • All looping music is looping, and all non-looping music isn't looping
  • There are exactly 64 venture cards
  • IF Venture card 45 is active, then there must be both an arcade & take a break square
  • IF Venture card 125 is active, then there must be both an arcade & boon square
  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
  • Max dice roll is below 10
  • You can't travel between three sets of doors in one roll

IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors
  • You can't travel between two sets of doors in one roll

IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll
  • Venture card 87 is inactive

IF max dice roll is 6:

  • Venture card 87 is inactive
  • Venture card 115 is inactive
  • Balloonport test has been completed on emulator OR console
  • Balloonport test has been completed on console
  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)
  • A full game of the board has been played by humans
  • All music has been tested and volumes are OK

@phellen007
Copy link
Contributor Author

Fortunapolis

  • Board passes validation script
  • Files are in correct folders
  • All FRBs pass possible paths check (under 70 iirc)
  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)
  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
  • All backstreet destinations are as intended
  • YAML is formatted correctly
  • YAML has author and changelog
  • YAML has Author's URL (or doesn't have one if not wanted)
  • Files and folders have no special characters / spaces / capitalisations
  • Map icon is included, follows existing template, and is correctly implemented in yaml
  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
  • Music is properly implemented and uploaded to server
  • All looping music is looping, and all non-looping music isn't looping
  • There are exactly 64 venture cards
  • IF Venture card 45 is active, then there must be both an arcade & take a break square
  • IF Venture card 125 is active, then there must be both an arcade & boon square
  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
  • Max dice roll is below 10
  • You can't travel between three sets of doors in one roll

IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors
  • You can't travel between two sets of doors in one roll

IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll
  • Venture card 87 is inactive

IF max dice roll is 6:

  • Venture card 87 is inactive
  • Venture card 115 is inactive
  • Balloonport test has been completed on emulator OR console
  • Balloonport test has been completed on console
  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)
  • A full game of the board has been played by humans
  • All music has been tested and volumes are OK

adjusted the author name to phellen007
V3: added a backstreet E to the board that leads back to the center isle in order to slightly increase the chance a switch will be pressed and so that area is used more often than just at the start of the game.
@phellen007
Copy link
Contributor Author

Fortune Gate

  • Board passes validation script
  • Files are in correct folders
  • All FRBs pass possible paths check (under 70 iirc)
  • All paths are functioning as intended (including doors and yoshi lifts and magmalices)
  • There is nowhere you can get stuck and cause a softlock (accounting for warp cards & balloonports)
  • All backstreet destinations are as intended
  • YAML is formatted correctly
  • YAML has author and changelog
  • YAML has Author's URL (or doesn't have one if not wanted)
  • Files and folders have no special characters / spaces / capitalisations
  • Map icon is included, follows existing template, and is correctly implemented in yaml
  • Thumbnails for each board state are included (and they're accurate as of the latest versions of the frb files)
  • Music is properly implemented and uploaded to server
  • All looping music is looping, and all non-looping music isn't looping
  • There are exactly 64 venture cards
  • IF Venture card 45 is active, then there must be both an arcade & take a break square
  • IF Venture card 125 is active, then there must be both an arcade & boon square
  • There's nowhere you can get stuck by randomly warping from venture card 83, OR venture card 83 is inactive
  • Max dice roll is below 10
  • You can't travel between three sets of doors in one roll

IF max dice roll is 9:

  • There are no doors.

IF max dice roll is 8:

  • There are no two-way doors
  • You can't travel between two sets of doors in one roll

IF max dice roll is 7:

  • You can't travel between two sets of doors in one roll
  • Venture card 87 is inactive

IF max dice roll is 6:

  • Venture card 87 is inactive
  • Venture card 115 is inactive
  • Balloonport test has been completed on emulator OR console
  • Balloonport test has been completed on console
  • At least three full games of the board have been completed by CPUs (see gecko codes to help speed this up dramatically)
  • A full game of the board has been played by humans
  • All music has been tested and volumes are OK

@Sophilautia Sophilautia merged commit 5da2e3e into FortuneStreetModding:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants