refactor: Shrink interface of KurtEvent and rename as KurtStream #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @InfraK, we want to shrink the interface a bit because it will lessen the impact of future changes to the final event structure. In doing so, we also decided to rename some things, such that the word `result` is only used for the final event of the stream, rather than the entire stream itself. BREAKING CHANGE: `finalText` and `finalData` have been removed, and some types have been renamed
InfraK
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @InfraK, we want to shrink the interface a bit because it will lessen the impact of future changes to the final event structure.
In doing so, we also decided to rename some things, such that the word
resultis only used for the final event of the stream, rather than the entire stream itself.BREAKING CHANGE:
finalTextandfinalDatahave been removed, and some types have been renamed