Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usage/fingerprint metadata to KurtResult for KurtVertexAI adapter #46

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jemc
Copy link
Collaborator

@jemc jemc commented Jun 26, 2024

This implements the new optional metadata field of the KurtResult interface to provide the total input and output tokens. Note that no system fingerprint is available from Vertex AI's Gemini API, so that is omitted here. If it ever becomes available, we can add it.

Note that this commit involves regenerating all the test snapshots because we are now capturing and relying on more from the upstream Vertex AI responses.

…I` adapter

This implements the new optional `metadata` field of the `KurtResult` interface to provide the total
input and output tokens. Note that no system fingerprint is available from Vertex AI's Gemini API,
so that is omitted here. If it ever becomes available, we can add it.

Note that this commit involves regenerating all the test snapshots because we are now capturing and
relying on more from the upstream Vertex AI responses.
@jemc jemc requested a review from theoremonemehdi June 26, 2024 21:03
@jemc jemc self-assigned this Jun 26, 2024
@jemc jemc merged commit 9ba96be into main Jun 26, 2024
1 check passed
@jemc jemc deleted the feat/vertex-ai-metadata branch June 26, 2024 22:51
Copy link

🎉 This PR is included in version @formula-monks/kurt-vertex-ai-v1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants