feat: support parallel tool calls in KurtVertexAI with generateWithOptionalTools
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoremonemehdi
approved these changes
May 31, 2024
InfraK
reviewed
May 31, 2024
InfraK
reviewed
May 31, 2024
…non-empty arrays See discussion here for motivation: #37 (comment)
|
@InfraK - I've added a new commit refactoring to type-guarded array destructuring as discussed in your feedback (applied for both |
InfraK
reviewed
Jun 4, 2024
| * Return true if this array has at least one element, also refining the | ||
| * Typescript type to indicate that the first element won't be undefined. | ||
| */ | ||
| function isNonEmptyArray<T>(array: T[]): array is [T, ...T[]] { |
There was a problem hiding this comment.
It would make sense to export this from a utils package at some point
There was a problem hiding this comment.
That's something I'd love to avoid if we can 🙃
InfraK
approved these changes
Jun 4, 2024
|
🎉 This PR is included in version @formula-monks/kurt-vertex-ai-v1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @formula-monks/kurt-open-ai-v1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
KurtVertexAIadapter to handle the case of multiple parallel tool calls from the LLM, when being used with thegenerateWithOptionalToolsmethod ofKurt.Similar to PR #35, this PR resolves part of issue #33