Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog - v7 breaking notes #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
**Breaking Changes:**
* we have dropped support for `es5` transpiled output
* we target `es2015` for our transpilation now
* `swipeable` utilizes object/array spread & const/let natively
* `swipeable` utilizes object spread & const/let natively
* **NOTE** - [tsc/typescript compiler](https://www.typescriptlang.org/tsconfig#target) still transpiles object spreads to `Object.assign`, so this may not actually be a breaking change
* see comment for more details: [#289 (comment)](https://github.com/FormidableLabs/react-swipeable/pull/289#issuecomment-1168553572)
* `preventScrollOnSwipe` - "new" prop. Replaces `preventDefaultTouchmoveEvent`
* same functionality but renamed to be more explicit on its intended use
* **fixed bug** - where toggling this prop did not re-attach event listeners
Expand Down