Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update action/cache and action/setup-node #91

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

djm158
Copy link
Contributor

@djm158 djm158 commented Dec 18, 2024

Description

  • Previously used actions/cache to configure yarn cache - replaced with actions/setup-node
  • update any other usage of actions/cache to v4

Type of Change

  • Adding or updating CI (Actions)

How Has This Been Tested?

CI

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 79bbd46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use checkout@v4 and setup-node@v4 while we are making changes

@djm158 djm158 merged commit 89e7e39 into master Dec 19, 2024
2 checks passed
@djm158 djm158 deleted the chore/update-actions-cache branch December 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants