Merge pull request #86 from Titozzz/master

fix: object key being wrongly transformed

.changeset/purple-doors-begin.md

@@ -0,0 +1,5 @@
+---
+"babel-plugin-transform-define": patch
+---
+
+Addresses #85, avoids replacing object keys.

.eslintignore

@@ -1,3 +1,4 @@
 node_modules
 test/binding
 test/import-identifiers
+test/object-keys

lib/index.js

@@ -92,9 +92,14 @@ const plugin = function ({ types: t }) {
       Identifier(nodePath, state) {
         const binding = nodePath.scope.getBinding(nodePath.node.name);
 
-        // Don't transform import idenifiers. This is meant to mimic webpack's
-        // DefinePlugin behavior.
-        if (binding || isImportIdentifier(nodePath)) {
+        if (
+          binding
+          // Don't transform import identifiers. This is meant to mimic webpack's
+          // DefinePlugin behavior.
+          || isImportIdentifier(nodePath)
+          // Do not transform Object keys unless they are computed like {[key]: value}
+          || nodePath.key === "key" && nodePath.parent.computed === false
+        ) {
           return;
         }
 

test/index.js

@@ -201,6 +201,17 @@ describe("babel-plugin-transform-define", () => {
         path.join(__dirname, "./binding/actual.js"),
         path.join(__dirname, "./binding/expected.js"), babelOpts);
     });
+
+    it("should not transform object keys unless they are computed", () => {
+      const babelOpts = getBabelOps({
+        __DEV__: true,
+        __DEV2__: "true"
+      });
+
+      return assertTransform(
+        path.join(__dirname, "./object-keys/actual.js"),
+        path.join(__dirname, "./object-keys/expected.js"), babelOpts);
+    });
   });
 
   describe("unit tests", () => {

test/object-keys/actual.js

@@ -0,0 +1,23 @@
+const obj = {
+    __DEV__
+  };
+  const obj1 = {
+    __DEV__: "test"
+  };
+  const obj2 = {
+    __DEV__: __DEV__
+  };
+  const obj3 = {
+    "__DEV__": __DEV__
+  };
+  const obj4 = {
+    ["__DEV__"]: __DEV__
+  };
+
+  const obj5 = {
+    [__DEV__]: __DEV__
+  };
+
+  const obj6 = {
+    [__DEV2__]: __DEV2__
+  };

test/object-keys/expected.js

@@ -0,0 +1,22 @@
+"use strict";
+
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
+var obj = {
+  __DEV__: true
+};
+var obj1 = {
+  __DEV__: "test"
+};
+var obj2 = {
+  __DEV__: true
+};
+var obj3 = {
+  "__DEV__": true
+};
+
+var obj4 = _defineProperty({}, "__DEV__", true);
+
+var obj5 = _defineProperty({}, true, true);
+
+var obj6 = _defineProperty({}, "true", "true");