Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lumen to Laravel Converter #36

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Lumen to Laravel Converter #36

wants to merge 9 commits into from

Conversation

tomahock
Copy link
Member

This pull request includes the changes for converting your Lumen application to a Laravel application. Feel free to commit any additional changes to the shift-120380 branch.

Before merging, you need to:

  • Checkout the shift-120380 branch
  • Verify your dependencies are compatible with Laravel
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, try with --no-scripts)
  • Thoroughly test your application

If you need help with your upgrade, check out the Human Shifts.

@laravel-shift
Apply Laravel coding style
1b0b17a 
Shift automatically applies the Laravel coding style - which uses the PSR-12 coding style as a base with some minor additions.

You may customize the code style applied by configuring [Pint](https://laravel.com/docs/pint), [PHP CS Fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer), or [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) for your project root.

For more information on customizing the code style applied by Shift, [watch this short video](https://laravelshift.com/videos/shift-code-style).
@laravel-shift
Migrate to Laravel folder structure
f7b5b10
@laravel-shift
Shift core files
8bcd63a
@laravel-shift
Remap controller inheritance
d6de006
@laravel-shift
Migrate routes
0c3ea09
@laravel-shift
Add Laravel's testing layer
5485713
@laravel-shift
Configure Composer for Laravel
e5138da
@laravel-shift
Shift cleanup
e13200f
@laravel-shift
Add Laravel dependencies
96a8702
@tomahock
Copy link
Member Author

⚠️ You should compare your .env file to the Laravel example .env file to ensure yours contains all of the environment variables for a Laravel application. Be sure to leverage environment variables whenever possible to make future upgrades easier.

@tomahock
Copy link
Member Author

⚠️ Shift detected a customized base TestCase class. In order to run your tests with Laravel, you should compare yours to the Laravel version and merge any changes.

Afterwards, you should attempt to run your test suite and make any additional changes to your configuration and tests for Laravel.

@tomahock
Copy link
Member Author

❌ Shift was unable to migrate some of your files to Laravel. Shift moved these files to .unshifted-lumen-files. You will need to review the files within this folder and merge any customizations manually.

@tomahock
Copy link
Member Author

ℹ️ Once you have verified the conversion of your Lumen application to Laravel, you may use the Laravel Shifts to upgrade to the latest version of Laravel.

@tomahock
Copy link
Member Author

❌ PHP syntax errors were detected after running your Shift. Often these are simply differences between the PHP version on the Shift server (8.2) and your project. Occasionally they are misplaced lines or duplicate import statements.

You may quickly check the PHP syntax locally by running php -l on the following files:

  • routes/api.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomahock @laravel-shift