Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added dummy AllOutput to old API #280

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

RyanDavies19
Copy link
Collaborator

This adds a dummy AllOutput function to the old API wrapper that prints a message stating "In version 2, AllOutput is automatically called by MoorDynStep". This reduces warning messages when using the old API. This was seen when updating the WECSim libraries in WEC-Sim/MoorDyn#7.

@sanguinariojoe, let me know if there is a better way to print the message here. I didn't see anything in the C header files that allowed for the use of LOGMSG.

@RyanDavies19
Copy link
Collaborator Author

Apologies for the spam here with testing, windows compiling is my nemesis.

In order to keep compilers happy, I renamed the AllOutput function to WriteOutputs. This matches what is in the MD-F code, and IMO is more clear about what is happening.

@sanguinariojoe
Copy link
Collaborator

@sanguinariojoe, let me know if there is a better way to print the message here. I didn't see anything in the C header files that allowed for the use of LOGMSG.

You can use MoorDyn_Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants