Docs update: typos, more references, and updated FF file #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! This PR will introduce some conflicts on #182. I suggest the following:
Is that OK? |
| @@ -108,11 +108,11 @@ moordyn::MoorDyn::MoorDyn(const char* infilename, int log_level) | |||
| _basepath = _filepath.substr(0, lastSlash + 1); | |||
| } | |||
|
|
|||
| LOGMSG << "\n Running MoorDyn (v2.0.0, 2023-09-18)" << endl | |||
| LOGMSG << "\n Running MoorDyn (v2.3.1, 2024-5-24)" << endl // TODO: can we automate this? | |||
There was a problem hiding this comment.
The version for sure! The date would be quite annoying... However I think we can just drop it, since we have now automated releases with the timestamp. Everyone can check when do we release a new version
There was a problem hiding this comment.
Agreed, as long as the version is up to date users can reference the release.
|
@sanguinariojoe that sounds like a good plan. I will have more reg tests up next week for comparison. Let me know if there are any you want to compare. |
|
I have changed my mind... I am merging this, launching a patch release, and then we can continue with the other tasks (verification and time marching) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typos found and/or reported by users. Aims to clear up common questions seen on OepnFAST help pages. Updates the FAST.Farm example to be consistent with current capabilities. Adds more references to publications about feature improvements.