fix: goldens

Floating-Dartists · Dec 20, 2023 · 2b257b5 · 2b257b5
1 parent 77a2742
commit 2b257b5
Show file tree

Hide file tree

Showing 11 changed files with 5 additions and 7 deletions.
diff --git a/lib/src/components/buttons/primary.dart b/lib/src/components/buttons/primary.dart
@@ -31,8 +31,7 @@ class DSFRPrimaryButton extends DSFRGroupeableButton {
     final dsfrTypography = dsfrTheme.typography;
     final dsfrButtonStyle = dsfrTheme.buttonStyle;
 
-    final scale = MediaQuery.textScalerOf(context)
-        .scale(dsfrTypography.medium.fontSize ?? 1);
+    final scale = MediaQuery.textScalerOf(context).textScaleFactor;
     final double gap =
         scale <= 1 ? 8 : lerpDouble(8, 4, math.min(scale - 1, 1))!;
 

diff --git a/lib/src/components/buttons/secondary.dart b/lib/src/components/buttons/secondary.dart
@@ -30,8 +30,7 @@ class DSFRSecondaryButton extends DSFRGroupeableButton {
     final dsfrColors = dsfrTheme.colors;
     final dsfrButtonStyle = dsfrTheme.buttonStyle;
 
-    final scale = MediaQuery.textScalerOf(context)
-        .scale(dsfrTypography.medium.fontSize ?? 1);
+    final scale = MediaQuery.textScalerOf(context).textScaleFactor;
     final double gap =
         scale <= 1 ? 8 : lerpDouble(8, 4, math.min(scale - 1, 1))!;
 

diff --git a/lib/src/components/buttons/tertiary.dart b/lib/src/components/buttons/tertiary.dart
@@ -33,8 +33,7 @@ class DSFRTertiaryButton extends DSFRBaseButton {
     final dsfrColors = dsfrTheme.colors;
     final dsfrTypography = dsfrTheme.typography;
 
-    final scale = MediaQuery.textScalerOf(context)
-        .scale(dsfrTypography.medium.fontSize ?? 1);
+    final scale = MediaQuery.textScalerOf(context).textScaleFactor;
     final double gap =
         scale <= 1 ? 8 : lerpDouble(8, 4, math.min(scale - 1, 1))!;
 

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -24,6 +24,7 @@ dev_dependencies:
 
 flutter:
   generate: true
+  uses-material-design: true
   fonts:
     - family: Marianne
       fonts:

diff --git a/test/components/buttons/goldens/ci/primary_button_dark.png b/test/components/buttons/goldens/ci/primary_button_dark.png
diff --git a/test/components/buttons/goldens/ci/primary_button_light.png b/test/components/buttons/goldens/ci/primary_button_light.png
diff --git a/test/components/buttons/goldens/ci/secondary_button_dark.png b/test/components/buttons/goldens/ci/secondary_button_dark.png
diff --git a/test/components/buttons/goldens/ci/secondary_button_light.png b/test/components/buttons/goldens/ci/secondary_button_light.png
diff --git a/test/components/buttons/goldens/ci/tertiary_button_dark.png b/test/components/buttons/goldens/ci/tertiary_button_dark.png
diff --git a/test/components/buttons/goldens/ci/tertiary_button_light.png b/test/components/buttons/goldens/ci/tertiary_button_light.png
diff --git a/test/flutter_test_config.dart b/test/flutter_test_config.dart
@@ -13,7 +13,7 @@ Future<void> testExecutable(FutureOr<void> Function() testMain) async {
 
   return AlchemistConfig.runWithConfig(
     config: AlchemistConfig(
-      ciGoldensConfig: const CiGoldensConfig(tolerance: 0.001),
+      ciGoldensConfig: const CiGoldensConfig(tolerance: 0.01),
       theme: ThemeData(
         fontFamily: DSFRFonts.marianne,
         brightness: Brightness.light,