-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C Mode, Japanese version support and testing inline assembly #6
base: master
Are you sure you want to change the base?
Conversation
I'm sorry, this is a lot of changes. Could you briefly describe what changes have taken place? It seems like a lot of files were moved, possibly? Should this really be merged into master, as opposed to be put on its own feature branch? @StanHash Do you have any opinions or anything to add? |
3 new features as described in the title. It accepts new command line argument. Though it is lots of changes, all changes are in the standalone new mode, which compiles event scripts to assembly source files. I think it is okay to merge into the master branch because it doesn't affect the original functions. You can test whether old functions work before merging. |
This looks like this originated from a fork of a different version of the Event Assembler source (probably one of the original Nintenlord sources) and the progress from that was just dumped in here. Which makes this PR a big git mess, adding a lot of unused source files as well as one big unnecessary doc dump. Here is a list of files that have been added while not being referenced in the Core project (this may be inaccurate/incomplete, as I just made this quickly by hand):
It is up to Colorz whether we care or not for this to become even more of a mess than this already is. If it were up to me I would request this to be cleaned up before considering anything else. When it comes to the added features themselves I don't see any real reason to deny their inclusion (although I would like to know what was actually added/changed which is hard to do with the branch in its current state). |
Most of the file changes are from commit 1523c7f, which are useless. I forget the reason why I need those source files to build at first. |
This reverts commit 1523c7f.
The clean up is already done. |
b5ce680
to
485da02
Compare
…rsing language raws
Read README3.md for more info.