-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit to check for all things gymnasium/pettingzoo does #157
Conversation
@younik these two pre-commit hooks are failing on my local machine but seem to pass on here, not sure what to make of it. It seems pretty odd to have stuff like !pip install in a .py file because strictly speaking that's improper syntax unless it's a .ipynb, but maybe it's fine because the tutorials can be downloaded as an .ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looked through all the files to make sure there aren’t any extra changes besides removing white space and such, there’s some weird “deleted then re added the same thing” for svgs but don’t think it’s a problem
The tutorial was done for Jupyter notebook at the beginning but, yes, it is weird epecially because you can also download the .py version. I will fix it to work in python. |
Just bumping in case you forgot about this (not a huge deal but probably good to get these pre-commit hooks up to date) |
Also it might be worth doing pre-commit autoupdate to see if anything is old |
Description
Just figure might as well mirror things, the validate github workflows one I have found to be extremely helpful in local testing when making new CI stuff, and there's some other QOL stuff and making it cleaner
Fixes # (issue), Depends on # (pull request)
Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.