Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary genesis params and migration func #85

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Remove unnecessary genesis params and migration func #85

merged 5 commits into from
Nov 1, 2024

Conversation

thaarok
Copy link
Collaborator

@thaarok thaarok commented Nov 1, 2024 •
edited
Loading

  • Removed unnecessary parameters of setGenesisValidator (used only in genesis file generating)
  • Remove method migrateValidatorPubkeyUniquenessFlag (unnecessary for a new chain)
  • Fixed ISFC to match SFC (TODO: let SFC to implement ISFC!)
  • Added mappings params names
  • Use locked pragma
  • Compile for cancun

@thaarok thaarok requested a review from Mike-CZ November 1, 2024 05:22
Mike-CZ
Mike-CZ approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@Mike-CZ Mike-CZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just run npm run lint:fix command in the workspace before merging please.

@thaarok thaarok merged commit 20fc210 into sonic_sfc Nov 1, 2024
1 of 2 checks passed
@thaarok thaarok deleted the jk/remove-migrage-gen-params branch November 1, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-CZ Mike-CZ Mike-CZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaarok @Mike-CZ