Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OZ][L-02] Transfer and send Calls Are No Longer Considered Best Practice #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[OZ][L-02] Transfer and send Calls Are No Longer Considered Best Practice #111

wants to merge 1 commit into from

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Dec 13, 2024

This PR replaces transfer call with call as it is not considered best practise.

@Mike-CZ Mike-CZ requested a review from thaarok December 13, 2024 09:17
thaarok
thaarok approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@thaarok thaarok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.
ReentrancyGuard was suggested too, but it should not be necessary as this external call follows after all state changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaarok thaarok thaarok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-CZ @thaarok