Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constants manager #108

Open
wants to merge 1 commit into
base: mike/disable_initializers
Choose a base branch
from
Open

Update constants manager #108

wants to merge 1 commit into from

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Dec 13, 2024

This PR updates constants manager by:

  • fixing burnt fee and treasury fee share never exceeding 100% in sum
  • removing targetGasPowerPerSecond and gasPriceBalancingCounterweight as they are not used anymore
  • adding test coverage

It also updates NetworkInitializer to match values used on mainnet launch.

@Mike-CZ Mike-CZ requested a review from thaarok December 13, 2024 08:01
thaarok
thaarok approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaarok thaarok thaarok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-CZ @thaarok