Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deadcode check & delete dead code #357

Merged
merged 4 commits into from
Dec 3, 2024
Merged

add deadcode check & delete dead code #357

merged 4 commits into from
Dec 3, 2024

Conversation

facuMH
Copy link
Contributor

@facuMH facuMH commented Nov 28, 2024

This is a re-do of #351, which was mistakenly merged into main branch.

@facuMH facuMH self-assigned this Nov 28, 2024
@LuisPH3
Copy link
Contributor

LuisPH3 commented Nov 29, 2024

part of https://github.com/Fantom-foundation/sonic-admin/issues/25

HerbertJordan
HerbertJordan approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is 1:1 the same as was approved the last time.

@facuMH facuMH merged commit e1ccec0 into develop Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerbertJordan HerbertJordan HerbertJordan approved these changes

@jmpike jmpike Awaiting requested review from jmpike jmpike is a code owner

@thaarok thaarok Awaiting requested review from thaarok thaarok is a code owner

@jenikd jenikd Awaiting requested review from jenikd jenikd is a code owner

Assignees

@facuMH facuMH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facuMH @LuisPH3 @HerbertJordan