Generate different ports for each integration test net. #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisPH3
requested review from
jmpike,
thaarok,
HerbertJordan and
jenikd
as code owners
HerbertJordan
previously approved these changes
Nov 28, 2024
LuisPH3
force-pushed
the
luis/integration_tests_own_ports
branch
from
25ed064 to
df1ccca
Compare
|
After changing ports, a little issue was identified in network restart test. Test was updated to use a new client connection (using new port) |
- client needed to be regenerated - contract binding object needs to be re-bound using new client.
LuisPH3
force-pushed
the
luis/integration_tests_own_ports
branch
from
df1ccca to
1278d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change isolates each instance of an integration test by choosing a different (best-effort unused) set of ports, and turning off discovery protocol.
Although tests are currently not segregated, this PR enables the segregation of those into different processes, this change is currently waiting for the memory usage reduction.
This test enables developers to locally run multiple integration tests simultaneously.