Add integration test for rejected transactions because of insufficient balance #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuMH
requested review from
jmpike,
thaarok,
HerbertJordan and
jenikd
as code owners
LuisPH3
changed the title
facuMH
force-pushed
the
facundo/rejected_tx_test
branch
from
538529c to
54d1cec
Compare
HerbertJordan
requested changes
Nov 27, 2024
LuisPH3
requested changes
Nov 27, 2024
facuMH
force-pushed
the
facundo/rejected_tx_test
branch
from
54d1cec to
7365e00
Compare
LuisPH3
requested changes
Nov 27, 2024
LuisPH3
approved these changes
Nov 27, 2024
HerbertJordan
changed the title
HerbertJordan
changed the title
HerbertJordan
approved these changes
Nov 28, 2024
facuMH
force-pushed
the
facundo/rejected_tx_test
branch
3 times, most recently
from
37fd189 to
46130d8
Compare
facuMH
force-pushed
the
facundo/rejected_tx_test
branch
from
46130d8 to
bf041e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves https://github.com/Fantom-foundation/sonic-admin/issues/84
A test it added that specifically verifies that transactions are rejected if the signing account does not have enough balance to pay for
transferred value + gas_limit * max_fee_cap. This is tested for all 4 types of transactions.The test uses a slice of Tx instead of a map because of the issue fixed in #346