Add feature flag for rule change checks

opera/legacy_serialization.go

@@ -96,6 +96,9 @@ func (u Upgrades) EncodeRLP(w io.Writer) error {
 	if u.Sonic {
 		bitmap.V |= sonicBit
 	}
+	if u.CheckRuleChanges {
+		bitmap.V |= checkRuleChangesBit
+	}
 	return rlp.Encode(w, &bitmap)
 }
 
@@ -112,6 +115,7 @@ func (u *Upgrades) DecodeRLP(s *rlp.Stream) error {
 	u.London = (bitmap.V & londonBit) != 0
 	u.Llr = (bitmap.V & llrBit) != 0
 	u.Sonic = (bitmap.V & sonicBit) != 0
+	u.CheckRuleChanges = (bitmap.V & checkRuleChangesBit) != 0
 	return nil
 }
 

opera/marshal.go

@@ -13,8 +13,10 @@ func UpdateRules(src Rules, diff []byte) (Rules, error) {
 	changed.Name = src.Name
 
 	// check validity of the new rules
-	if err = changed.Validate(); err != nil {
-		return Rules{}, err
+	if changed.Upgrades.CheckRuleChanges {
+		if err = changed.Validate(); err != nil {
+			return Rules{}, err
+		}
 	}
 	return changed, nil
 }

opera/rules.go

@@ -18,14 +18,15 @@ import (
 )
 
 const (
-	MainNetworkID   uint64 = 0xfa
-	TestNetworkID   uint64 = 0xfa2
-	FakeNetworkID   uint64 = 0xfa3
-	DefaultEventGas uint64 = 28000
-	berlinBit              = 1 << 0
-	londonBit              = 1 << 1
-	llrBit                 = 1 << 2
-	sonicBit               = 1 << 3
+	MainNetworkID       uint64 = 0xfa
+	TestNetworkID       uint64 = 0xfa2
+	FakeNetworkID       uint64 = 0xfa3
+	DefaultEventGas     uint64 = 28000
+	berlinBit                  = 1 << 0
+	londonBit                  = 1 << 1
+	llrBit                     = 1 << 2
+	sonicBit                   = 1 << 3
+	checkRuleChangesBit        = 1 << 4
 
 	MinimumMaxBlockGas          = 1_000_000_000 // < must be large enough to allow internal transactions to seal blocks
 	MaximumMaxBlockGas          = math.MaxInt64 // < should fit into 64-bit signed integers to avoid parsing errors in third-party libraries
@@ -214,6 +215,8 @@ type Upgrades struct {
 	London bool
 	Llr    bool
 	Sonic  bool
+
+	CheckRuleChanges bool // < enables safety checks for rule updates
 }
 
 type UpgradeHeight struct {
@@ -302,12 +305,7 @@ func MainNetRules() Rules {
 			MaxBlockGas:             MinimumMaxBlockGas,
 			MaxEmptyBlockSkipPeriod: inter.Timestamp(1 * time.Minute),
 		},
-		Upgrades: Upgrades{
-			Berlin: true,
-			London: true,
-			Llr:    false,
-			Sonic:  true,
-		},
+		Upgrades: DefaultUpgrades(),
 	}
 }
 
@@ -323,12 +321,7 @@ func FakeNetRules() Rules {
 			MaxBlockGas:             MinimumMaxBlockGas,
 			MaxEmptyBlockSkipPeriod: inter.Timestamp(3 * time.Second),
 		},
-		Upgrades: Upgrades{
-			Berlin: true,
-			London: true,
-			Llr:    false,
-			Sonic:  true,
-		},
+		Upgrades: DefaultUpgrades(),
 	}
 }
 
@@ -345,6 +338,16 @@ func DefaultEconomyRules() EconomyRules {
 	return rules
 }
 
+func DefaultUpgrades() Upgrades {
+	return Upgrades{
+		Berlin:           true,
+		London:           true,
+		Llr:              false,
+		Sonic:            true,
+		CheckRuleChanges: true,
+	}
+}
+
 // FakeEconomyRules returns fakenet economy
 func FakeEconomyRules() EconomyRules {
 	return DefaultEconomyRules()

opera/validate.go

@@ -40,9 +40,6 @@ func validateDagRules(rules DagRules) error {
 func validateEmitterRules(rules EmitterRules) error {
 
 	var issues []error
-	if rules.Interval < inter.Timestamp(100*time.Millisecond) {
-		issues = append(issues, errors.New("Emitter.Interval is too low"))
-	}
 	if rules.Interval > inter.Timestamp(10*time.Second) {
 		issues = append(issues, errors.New("Emitter.Interval is too high"))
 	}