Add file error handling and structure handlers factory method #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Added a few thoughts, but need to look through the changes more carefully when the suggestions have been processed.
I think we will have to add definitions of what error results mean for the state of the object that emitted the error. For instance, if a file operation fails, are subsequent operations allowed? Or in case a page pool fetch fails, can future get, flush, and close operations be trusted?
added 15 commits
December 19, 2022 12:51
# Conflicts: # cpp/backend/common/file.cc # cpp/backend/common/file.h # cpp/backend/common/file_benchmark.cc # cpp/backend/common/file_test.cc # cpp/backend/common/page.h # cpp/backend/common/page_pool.h # cpp/backend/common/page_pool_benchmark.cc # cpp/backend/common/page_pool_test.cc # cpp/backend/index/file/index.h # cpp/backend/store/file/store.h
Mike-CZ
changed the title
Mike-CZ
changed the title
Mike-CZ
changed the title
added 2 commits
January 16, 2023 15:50
HerbertJordan
requested changes
Jan 17, 2023
HerbertJordan
requested changes
Jan 17, 2023
added 4 commits
January 18, 2023 21:45
# Conflicts: # cpp/backend/common/BUILD # cpp/backend/depot/BUILD # cpp/backend/index/BUILD # cpp/backend/index/leveldb/BUILD # cpp/backend/store/BUILD # cpp/common/BUILD # cpp/common/status_util.h # cpp/common/status_util_test.cc # cpp/state/BUILD
|
Added list of things that needs to be done according to this PR. |
HerbertJordan
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.