Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Config #893

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Refactor Config #893

merged 2 commits into from
Dec 11, 2023

Conversation

wsodsong
Copy link
Collaborator

@wsodsong wsodsong commented Dec 6, 2023

Description

Add a context to share log and cfg between config functions.

This change also Fixes #886

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (changes that do NOT affect functionality)

Add a context to share log and cfg between config functions.
Copy link
Collaborator

@cabrador cabrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add factory func for configContext you can then use it in the tests as well.

utils/config.go Outdated Show resolved Hide resolved
utils/config.go Outdated Show resolved Hide resolved
utils/config.go Outdated Show resolved Hide resolved
utils/config.go Outdated Show resolved Hide resolved
utils/config.go Show resolved Hide resolved
utils/config.go Show resolved Hide resolved
utils/config.go Outdated Show resolved Hide resolved
@wsodsong wsodsong requested a review from cabrador December 8, 2023 08:56
@wsodsong wsodsong merged commit 19997cf into develop Dec 11, 2023
1 check passed
@wsodsong wsodsong deleted the wasuwee/refactor-config branch January 16, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants