Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade geth to v1.14 #1118

Merged
merged 26 commits into from
Jun 21, 2024
Merged

Upgrade geth to v1.14 #1118

merged 26 commits into from
Jun 21, 2024

Conversation

wsodsong
Copy link
Collaborator

@wsodsong wsodsong commented Jun 17, 2024 •
edited
Loading

Description

This PR upgrades geth to version 1.14. The change includes

  • support new state db facades
  • balance type change to *uint256
  • change message type to core.Message

Changes which will be resolved in a later PR

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (changes that do NOT affect functionality)
  • Adds or updates testing

@wsodsong wsodsong requested review from cabrador, HerbertJordan, matejmode and rpl-ffl and removed request for cabrador and HerbertJordan June 17, 2024 10:54
cabrador
cabrador requested changes Jun 17, 2024
View reviewed changes
cmd/aida-sdb/record.go Outdated Show resolved Hide resolved
cmd/aida-stochastic-sdb/stochastic/record.go Outdated Show resolved Hide resolved
cmd/aida-vm-adb/run_vm_adb_test.go Show resolved Hide resolved
cmd/aida-vm-adb/run_vm_adb_test.go Show resolved Hide resolved
ethtest/transaction.go Outdated Show resolved Hide resolved
state/carmen.go Outdated Show resolved Hide resolved
state/carmen.go Show resolved Hide resolved
state/carmen.go Outdated Show resolved Hide resolved
state/carmen_test.go Outdated Show resolved Hide resolved
state/memory.go Outdated Show resolved Hide resolved
cabrador
cabrador reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@cabrador cabrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge the PR with TransientStorage and then use it here.

utils/default_config.go Show resolved Hide resolved
tracer/operation/operation_test.go Show resolved Hide resolved
tracer/operation/hassuicided.go Outdated Show resolved Hide resolved
HerbertJordan
HerbertJordan approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for putting in all that effort to get this upgrade done!

executor/transaction_processor.go Show resolved Hide resolved
rpc/evm.go Outdated Show resolved Hide resolved
state/carmen.go Outdated Show resolved Hide resolved
state/carmen.go Outdated Show resolved Hide resolved
state/carmen_test_enviroment.go Outdated Show resolved Hide resolved
@wsodsong
Copy link
Collaborator Author

Waiting for results of manual tests.

@wsodsong wsodsong requested a review from cabrador June 20, 2024 09:48
@wsodsong wsodsong marked this pull request as ready for review June 20, 2024 09:51
@wsodsong
Copy link
Collaborator Author

Waiting for results of manual tests.

  • Aida-vm mainnet full range: passed
  • Aida-vm testnet full range: passed
  • Aida-vm-sdb testnet full range: passed

@wsodsong wsodsong removed the request for review from matejmode June 21, 2024 06:20
HerbertJordan
HerbertJordan approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all that work!

cabrador
cabrador approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@cabrador cabrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

state/chain_conduit.go Outdated Show resolved Hide resolved
state/carmen.go Outdated Show resolved Hide resolved
@wsodsong wsodsong force-pushed the ws/upgrade-geth-1.14 branch from 410fbc6 to 31a5142 Compare June 21, 2024 09:35
@wsodsong wsodsong merged commit 15fcbcb into develop Jun 21, 2024
4 checks passed
HerbertJordan pushed a commit that referenced this pull request Jun 27, 2024
@wsodsong @HerbertJordan
Upgrade geth to v1.14 (#1118)
52e5627 
Upgrade geth and aida's dependencies to support geth v1.14
@wsodsong wsodsong deleted the ws/upgrade-geth-1.14 branch August 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabrador cabrador cabrador approved these changes

@HerbertJordan HerbertJordan HerbertJordan approved these changes

@rpl-ffl rpl-ffl Awaiting requested review from rpl-ffl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsodsong @HerbertJordan @cabrador