Fix: Properly extend the stack in ModifyArgInjector.
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old logic doesn't really make any sense and the calculated extension usually ended up being negative. Instead, we just make room for our possible receiver and all of our args.
modmuss50
approved these changes
Jun 8, 2024
|
Going to merge this now, let me know if you want a release with just this, or if it can wait a bit until before loader 0.16. |
|
Haven't seen it cause any problems outside my own test scenarios, it's not urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic doesn't really make any sense and the calculated extension usually ended up being negative. Instead, we just make room for our possible receiver and all of our args.