Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate MixinErrors as MixinApplicatorExceptions with context #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Propagate MixinErrors as MixinApplicatorExceptions with context #118

wants to merge 1 commit into from

Commits on Aug 14, 2023

  1. Propagate MixinErrors as MixinApplicatorExceptions with context 

    Many internal Mixin errors, particularly InjectionErrors, are raised as
the result of invalid mixins (e.g. failed injection check as the mixin
was compiled for a different Minecraft version) or mixin conflicts that
are not issues in Mixin itself. These MixinErrors don't currently get
handled by IMixinErrorHandler handlers, and when propagated to more
generic error handling code don't have much machine-readable context.

Wrapping these errors in MixinApplicatorExceptions allows them to be
handled by existing IMixinErrorHandler implementations in the apply
error phase, and attaching this context allows Mixin callers to reason
about the cause of mixin errors and present them in a more user-friendly
way.

MixinApplicatorStandard seems like the most appropriate place to insert
context of the current mixin and activity stack similarly to the
existing Exception handling, and doesn't require MixinError to change
how it is constructed and used by internal Mixin code.
    @comp500
    comp500 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d121385 View commit details
    Browse the repository at this point in the history